[patch]reversed logic in disconnect testing of hiddev
From: Oliver Neukum <oliver@neukum.org>
Date: 2009-01-28 08:29:42
From: Oliver Neukum <oliver@neukum.org>
Date: 2009-01-28 08:29:42
The logic for testing for disconnection is reversed in an ioctl leading to false reports of disconnection. Signed-off-by: Oliver Neukum <redacted> Tested-by: Folkert van Heusden <redacted> Hi, this should go into the next rc of 2.6.29 Regards Oliver ---
--- linux-2.6/drivers/hid/usbhid/hiddev.c.alt 2009-01-26 20:03:10.000000000 +0100
+++ linux-2.6/drivers/hid/usbhid/hiddev.c 2009-01-26 20:03:17.000000000 +0100@@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *fi case HIDIOCGSTRING: mutex_lock(&hiddev->existancelock); - if (!hiddev->exist) + if (hiddev->exist) r = hiddev_ioctl_string(hiddev, cmd, user_arg); else r = -ENODEV;