Thread (1 message) 1 message, 1 author, 2009-01-13

Re: [PATCH] input: input: stop autorepeat timer on key release

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2009-01-13 08:56:53

Possibly related (same subject, not in this thread)

On Mon, 2009-01-12 at 21:02 -0800, Dmitry Torokhov wrote:
quoted
quoted
This introduces a slight change in behaviour (the key that is released
may not be one that is being autorepeated) but I think it still makes
sense to do it.
Hmm, good point, I thought it didn't, but it does when you press a, b
wait, release a then b doesn't continue autorepeating. Seems like a
corner case though, so I agree. We could fix that by checking which key
is being autorepeated though, I'd think, see below (untested as of now)
I actually think the original change was better - sometimes when shift or
alt or ctrl key gets stuck it takes time to figure out what happened. If
we stop autorepeat upon release of any key it will recover much quicker.
Heh, good point too. Well, I was just confused by seeing the timer in
there until I realised what was going on, so feel free to take either
patch. :)

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help