Re: [PATCH] Make PNP IDs all uppercase
From: Carlos Corbacho <hidden>
Date: 2009-01-22 23:07:13
Also in:
linux-acpi, lkml
Possibly related (same subject, not in this thread)
- 2009-01-21 · Re: [PATCH] Make PNP IDs all uppercase · Kay Sievers <hidden>
- 2009-01-21 · Re: [PATCH] Make PNP IDs all uppercase · Bjorn Helgaas <hidden>
- 2009-01-21 · Re: [PATCH] Make PNP IDs all uppercase · Alessandro Zummo <hidden>
- 2009-01-21 · Re: [PATCH] Make PNP IDs all uppercase · Philipp Kohlbecher <hidden>
- 2009-01-21 · Re: [PATCH] Make PNP IDs all uppercase · Bjorn Helgaas <hidden>
On Sunday 18 January 2009 14:02:32 Philipp Kohlbecher wrote:
If I understand correctly, ACPI _HIDs (including PNP IDs) should be all uppercase, including the hex digits, cf. ACPI Specification 3.0b [1], pp. 162-3 and acpi_glb_hex_to_ascii[] in drivers/acpi/utilities/utglobal.c.
ACPI-WMI violates the spec here.
quoted hunk
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 8a8b377..79b8af7 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c@@ -84,7 +84,7 @@ static int acpi_wmi_add(struct acpi_device *device); static const struct acpi_device_id wmi_device_ids[] = { {"PNP0C14", 0}, - {"pnp0c14", 0}, + {"PNP0C14", 0}, {"", 0}, }; MODULE_DEVICE_TABLE(acpi, wmi_device_ids);diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c index 8473fe5..18c9335 100644
NAK to the ACPI-WMI changes. There really is a pnp0c14 and a PNP0C14, and removing the lower case version breaks ACPI-WMI on my laptop. -Carlos -- E-Mail: carlos@strangeworlds.co.uk Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D