Thread (11 messages) 11 messages, 4 authors, 2009-01-01

Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast

From: Mike Frysinger <hidden>
Date: 2009-01-01 07:41:28
Also in: linux-sh, lkml

On Tuesday 30 December 2008 15:27:05 Adrian McMenamin wrote:
Adding maple mouse with proper __devexit_p() handling
this kind of patch revision info typically goes below the --- marker and  the 
patch itself gets "v2", "v3", etc... header markers

otherwise, driver looks OK to me.  thanks for your dreamcast work.
Acked-by: Mike Frysinger <redacted>
+	mse = kzalloc(sizeof(struct dc_mouse), GFP_KERNEL);
personally i find this style less likely to rot:
mse = kzalloc(sizeof(*mse), GFP_KERNEL);
-mike

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help