Re: New Force Feedback device support - GreenAsia 0x12
From: Łukasz Lubojański <hidden>
Date: 2008-12-04 20:35:40
Attachments
- greenasia.patch [text/x-diff] 1593 bytes · preview
From: Łukasz Lubojański <hidden>
Date: 2008-12-04 20:35:40
2008/11/29 Jiri Kosina [off-list ref]:
On Fri, 28 Nov 2008, Łukasz Lubojański wrote:quoted
quoted
It seems the protocol resembles more the hid-lg2ff one. The differences are the additional 0xfa 0xfe 0x0 report sent to the device, and the missing 0xf3 stop command.Yep - different reports are send in case of Pantherlord and GreenAsia 0x12 - It could be implemented in it but it will require checking what hardware is used and send different reports.OK, so as the reports are not really identical, and in the future we might discover that there are many more other Greenasia devices which require a slightly different handling as well, I would rather prefer to have it as a separate driver, to avoid additions of here-and-there device-specific quirks to random places in the code. That's exactly what we are trying to avoid with the HID bus approach in the first place. So I think separate driver is fine. Thanks to both of you. -- Jiri Kosina SUSE Labs
Hi, Here is new version of the GreenAsia patch - I hope this time everything will be OK. It is based on the Pantherlord. Sorry to take so long but I have problems with the 2.6.28 (2.6.28-rc6 was not loading my driver and 2.6.28-rc7 is crashing when IO APIC is enabled). Anyway I done it and I'm waiting for your feedback :D regards Lukasz Lubojanski