On Tue, Dec 30, 2008 at 01:15:01AM -0800, Dmitry Torokhov wrote:

On Monday 29 December 2008 22:03:35 Alexander E. Patrakov wrote:

quoted

This is still slightly wrong. The mouse does work, but is misnamed in
the dmesg output and in /proc/bus/input/devices:

psmouse serio1: ID: 10 00 64<6>elantech.c: Elantech version query result
0x00, 0x01, 0x64.
elantech.c: Probably not a real Elantech touchpad. Aborting.
input: ImExPS/2 Elantech Touchpad as /class/input/input8

Yeah, elantech_init() is too late, we need to do something in
elantech_detect()... 

Well, we could also move that Elantech version query and test for sane
values into elantech_detect().  However, because we have no private data
structure at that time it would mean we have to do the same query again in
elantech_init() to store fw_version_maj and fw_version_min.

Maybe we need to pull part of Logitech check (number of buttons for
example) from logips2pp.c.

I think the solution above is simpler although maybe not as pretty... :)


Arjan