Re: [patch]fix memleak in error case of hiddev
From: Jiri Slaby <hidden>
Date: 2008-11-12 15:11:17
From: Jiri Slaby <hidden>
Date: 2008-11-12 15:11:17
On 11/12/2008 03:55 PM, Oliver Neukum wrote:
Am Mittwoch, 12. November 2008 15:48:38 schrieb Jiri Kosina:quoted
+ if (!list->hiddev->open++) { + if (list->hiddev->exist) {The order of checks is inverted. If the device no longer exists opening should fail, even if the device is already opened. Didn't I post a patch that does this? My memory is a bit clouded.
This is very old (and broken) version of the patch. I remember I already commented some issues contained in this one and you did fix them later ;).