Oliver Neukum napsal(a):

Am Dienstag, 4. November 2008 16:00:06 schrieb Alan Stern:

quoted

On Tue, 4 Nov 2008, Oliver Neukum wrote:

quoted

Am Montag, 3. November 2008 20:58:11 schrieb Jiri Slaby:

quoted

Hi.

quoted

this is the cleanup of hiddev against current vanilla. What do you think?

See my comments below.

Hi,

there still is a race of disconnect() with ioctl(). It seems like that
code still operates under the assumption that both methods take
BKL. Do you prefer a conservative fix with selective application of BKL
or introduction of a new mutex?

It's none of my business... but IMO we should try to move away from the 
BKL as much as possible.

This is true but hiddev is in a sense legacy code which should be replaced
with hidraw, so I tend to fix it conservatively.

Jiri K. is off for few days, I'm not responsible for the HID layer, he is, I
would let him to decide ;).