Re: Who broke cb8f488c33 patch? (was Re: [PATCH 1/1] USBHID: correct start/stop cycle)
From: Jiri Slaby <hidden>
Date: 2008-11-12 09:23:51
Also in:
lkml
From: Jiri Slaby <hidden>
Date: 2008-11-12 09:23:51
Also in:
lkml
On 11/12/2008 01:50 AM, Andrew Morton wrote:
quoted
quoted
let's fix it for good. Signed-off-by: Denys Vlasenko <redacted>--- linux-2.6.28-rc4/mm/mmap.c Mon Nov 10 01:36:15 2008 +++ linux-2.6.28-rc4.fix/mm/mmap.c Wed Nov 12 01:21:39 2008@@ -1704,7 +1704,7 @@ vma = find_vma_prev(mm, addr, &prev); if (vma && (vma->vm_start <= addr)) return vma; - if (expand_stack(prev, addr)) + if (!prev || expand_stack(prev, addr)) return NULL; if (prev->vm_flags & VM_LOCKED) { if (mlock_vma_pages_range(prev, addr, prev->vm_end) < 0)It looks like this was caused by me fixing rejects. That was the fancy include-lots-of-context-so-it-wont-apply patch.
Great, this one got fixed. Helge, did you proceed with bisecting which another commit breaks parics while having this one applied? Thanks.