Re: [PATCH 3/3] OLPC: touchpad driver (take 2)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2008-09-11 13:00:17
Also in:
lkml
Hi Andres, On Thu, Sep 11, 2008 at 01:01:24AM -0400, Andres Salomon wrote:
quoted hunk ↗ jump to hunk
@@ -114,7 +115,7 @@ ssize_t psmouse_attr_show_helper(struct device *dev, struct device_attribute *at ssize_t psmouse_attr_set_helper(struct device *dev, struct device_attribute *attr, const char *buf, size_t count); -#define PSMOUSE_DEFINE_ATTR(_name, _mode, _data, _show, _set) \ +#define PSMOUSE_DEFINE_ATTR(_name, _mode, _data, _protected_set, _show, _set) \ static ssize_t _show(struct psmouse *, void *data, char *); \ static ssize_t _set(struct psmouse *, void *data, const char *, size_t); \ static struct psmouse_attribute psmouse_attr_##_name = { \@@ -129,6 +130,7 @@ static struct psmouse_attribute psmouse_attr_##_name = { \ .data = _data, \ .show = _show, \ .set = _set, \ + .protected_set = _protected_set, \ }
I would rather you defined __PSMOUSE_DEFINE_ATTR() with 'protected' argument and then defined PSMOUSE_DEFINE_ATTR() through underscored version so that nothing else need to be changed. -- Dmitry