Re: [PATCH 2/2] input: mousedev: Emulate right and middle buttons for single-button touchpads
From: Henrik Rydberg <hidden>
Date: 2008-09-10 14:52:18
Also in:
lkml
Greetings Dmitry,
On Fri, Sep 05, 2008 at 03:19:56AM +0200, Henrik Rydberg wrote:quoted
On most linux-based systems, the right and middle buttons are used extensively. On computers lacking either of those buttons, such as the Apple Macbooks, emulation is needed. This patch adds emulation of the missing buttons via two-fingers-and-click and three-fingers- and-click operations, which has recently become standard, both in MacOS and in the Xorg synaptics driver.The standard way of emulating right and middle button presses for "button-deficient" devices is to use Macintosh emulation (MAC_EMUMOUSEBTN) that works not only for touchpads but for regular mice as well.
I have a hard time believing that in five years from now, people will still consider pressing a key on the keyboard the standard way to emulate a right click. Nevertheless, I can see the point in moving away from user-land decisions in the kernel. I will not pursue this one further, although it is a rather neat piece of functionality.
Overall I don't think we should enhance mousedev for scenarios where proper solution is to install Synaptics X driver. This also goes for your other patch improving tapping in mousedev.
Regarding the tapping patch; it is addressing the correctness of already implemented functionality. I can see nothing wrong with that. Henrik