Thread (3 messages) 3 messages, 2 authors, 2008-08-23

Usage of new KEY_NUMERIC_* codes in an existing driver (yealink)

flat view

From: Thomas Reitmayr <hidden>
Date: 2008-08-22 19:45:08

Hi,
I am in the process of extending the existing yealink driver, partly to
support various other models. The existing driver as included in the
current kernel uses the shift key to report the keys "*" and "#", but I
am hesitating to do the same bad "trick" for the other models.

As I would like to eventually submit the extended driver upstream, what
is the recommended strategy in my situation regarding usage of the new
KEY_NUMERIC_* codes? Use them only for the new models (which would
result in an ugly mix), or also update the codes for the existing
USB-P1K model (which would break userspace programs but finally fix
things for some foreign keyboard layouts), or for the existing USB-P1K
model report the old and the new codes (which might look like two key
presses)?

Thanks for your advice,
-Thomas

PS: The updated driver is available at
http://www.devbase.at/svn/view.cgi/yealink-module/trunk/?root=voip
(still including #if's reg. kernel versions, some comments to be
corrected, etc.)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help