Re: [rft]power management for usbtouch

On Thu, Jun 26, 2008 at 04:56:05PM +0200, Oliver Neukum wrote:

Am Donnerstag 26 Juni 2008 16:45:45 schrieb Ville Syrjälä:

quoted

On Thu, Jun 26, 2008 at 03:57:17PM +0200, Oliver Neukum wrote:

quoted

 MODULE_DEVICE_TABLE(usb, usbtouch_devices);
 
 static struct usb_driver usbtouch_driver = {
 	.name		= "usbtouchscreen",
 	.probe		= usbtouch_probe,
 	.disconnect	= usbtouch_disconnect,
+	.suspend	= usbtouch_suspend,
+	.resume		= usbtouch_resume,
+	.reset_resume	= usbtouch_resume,

What is the purpose of providing identical resume and reset_resume?
AFAICS reset_resume is only called if USB_QUIRK_RESET_RESUME is
enabled.

It is also called if you resume from STD if power was lost.

That's the case with USB_PERSIST and persist_enabled turned on right?
So the core will simply disconnect+reconnect the device if persistance
is not enabled (or if reset_resume is not provided). Hmm. I suppose it's
better to have a reset_resume than do the disconnect+reconnect trick
since then the input device will not disappear, making it more friendly
towards non-hotlug aware applications.

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html