Re: [patch]fix race between disconnect and open in usbtouch

On Thu, Jun 26, 2008 at 03:49:26PM +0200, Oliver Neukum wrote:

Am Donnerstag 26 Juni 2008 15:41:10 schrieb Ville Syrjälä:

quoted

quoted

--- linux-2.6.26-sierra/drivers/input/touchscreen/usbtouchscreen.c.alt        2008-06-26 15:23:34.000000000 +0200
+++ linux-2.6.26-sierra/drivers/input/touchscreen/usbtouchscreen.c    2008-06-26 15:23:38.000000000 +0200

@@ -973,8 +973,8 @@ static void usbtouch_disconnect(struct u

 
      dbg("%s - usbtouch is initialized, cleaning up", __FUNCTION__);
      usb_set_intfdata(intf, NULL);
-     usb_kill_urb(usbtouch->irq);
      input_unregister_device(usbtouch->input);
+     usb_kill_urb(usbtouch->irq);
      usb_free_urb(usbtouch->irq);
      usbtouch_free_buffers(interface_to_usbdev(intf), usbtouch);
      kfree(usbtouch);

I think you can just remove that usb_kill_urb() call since
usbtouch_close() has already called it by that time.

Are you sure?

Yes, calling dev->close for opened devices as part of unregister is done
by the input core.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html