Re: [patch]reliably killing urbs in yealink driver
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2008-06-26 14:26:43
Hi Oliver, On Thu, Jun 26, 2008 at 01:44:30PM +0200, Oliver Neukum wrote:
quoted hunk ↗ jump to hunk
@@ -809,8 +831,7 @@ static int usb_cleanup(struct yealink_de if (yld == NULL) return err; - usb_kill_urb(yld->urb_irq); /* parameter validation in core/urb */ - usb_kill_urb(yld->urb_ctl); /* parameter validation in core/urb */ + stop_traffic(yld);
stop_traffic is unneeded here since input core guarantees that close is called when you unregister and opened device. Do you have the hardware to test? If not I will fold stop_traffic back into yealink_close locally. -- Dmitry