Thread (11 messages) 11 messages, 7 authors, 2008-06-05

Re: [PATCH 1/2] atmel_tsadcc: Device driver for AT91SAM9RL Touchscreen

From: Haavard Skinnemoen <hidden>
Date: 2008-06-05 13:49:51

Justin Waters [off-list ref] wrote:
On Fri, 2008-04-25 at 17:10 -0400, Russell King - ARM Linux wrote:
quoted
quoted
+config TOUCHSCREEN_ATMEL_TSADCC
+     tristate "Atmel Touchscreen Interface"  
No dependencies.  So does this mean this'll build and link on an
x86 platform?
  
I was actually thinking that this IP will end up on an AVR32 platform as
well, so I intentionally tried to avoid making the driver too ARM
specific.  However, I definitely see the point of specifying
ARCH_AT91SAM9RL and worrying about adding additional support for new
platforms later, so I'll add that in.
Thanks for thinking about AVR32 as well :-)

I think adding a dependency on AT91 is the right thing to do for now. We
can always patch in "|| AVR32" later if/when this IP finds its way into
an AVR32 chip.

Though it looks like the only thing this driver uses that isn't
available on x86 is the clk API, so perhaps it would be best to depend
on HAVE_CLK assuming this patch gets merged:

http://lkml.org/lkml/2008/5/29/367

This would give the driver much better compile-testing coverage by
people who do allyesconfig builds and such on different platforms.

Haavard

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help