Re: multi-input quirk and skip output reports quirk
From: Anssi Hannula <hidden>
Date: 2008-04-04 14:40:06
Jiri Kosina wrote:
On Tue, 1 Apr 2008, Anssi Hannula wrote:quoted
quoted
quoted
I've encountered another multi-input device that needs the skip output reports quirk (as it contains force feedback output reports), 0925:8866. However, maybe we should use another approach, dropping HID_QUIRK_SKIP_OUTPUT_REPORTS. Why not just *not* register the input device for that report in case the report didn't contain anything that was mapped by hidinput_configure_usage(), in hidinput_connect()?as long as we still have the possibility to see the coming data in debug mode, I don't have objection to that.Okay.quoted
Are you going to make that patch?Not right now, maybe in a few weeks.I will meanwhile queue the patch below, ok? After the hidinput_connect() is refactored to ignore devices for which the mappings haven't been established, we could then remove all the devices for which we have HID_QUIRK_SKIP_OUTPUT_REPORTS altogether.
Ok.
BTW, do you happen to have any idea whether the Quad joypad needs this quirk too?
No, but I guess it is quite probable.
Thanks.
-- Anssi Hannula