Re: uinput oopses and bugs

davor emard wrote:

quoted

quoted

There is also a still issue with segfault and unkillable driver.
I upload custom FF effect, driver segfaults but doesn't exit
and becomes zombie

please test the attached patch

The patch now avoids the zombie lockup coming from segmentation
fault.  Thanks a lot, that is great step forward!

However it's still not clear to me why do I get this segmentation
fault when I try to upload a block of FF_CUSTOM sample data.
I made my code mainly from looking at the kernel source without
having any example - anyone on the list can point link to some small
code example?

in uinput-zombie, I've prepared the data in application, ioctl'ed them
to uinput event device and the uinput driver segfaults when
it tries to read the portion of  FF_CUSTOM data.

I think uinput needs special handling for FF_CUSTOM to deliver the ff
data to userspace. AFAIK the segfault occurs because the uinput driver
tries to read the data pointer, while the data is only in kernel and not
copied to userspace.

I haven't seen any driver yet, uinput or in-kernel, that supports
FF_CUSTOM, so this could've been overlooked quite easily. It is in my
TODO to implement it for PID devices, but I do not have time anytime soon.

-- 
Anssi Hannula