Thread (2 messages) 2 messages, 2 authors, 2008-03-24

[PATCH] Fix sh_keysc double free

flat view
STALE6773d

From: Magnus Damm <magnus.damm@gmail.com>
Date: 2008-03-21 11:14:18
Also in: linux-sh

Avoid double free situation from happening by removing input_free_device() 
after input_unregister_device(). Suggested by Dmitry Torokhov.

Signed-off-by: Magnus Damm <redacted>
---

 drivers/input/keyboard/sh_keysc.c |    1 -
 1 file changed, 1 deletion(-)
--- 0001/drivers/input/keyboard/sh_keysc.c
+++ work/drivers/input/keyboard/sh_keysc.c	2008-03-21 10:58:20.000000000 +0900
@@ -238,7 +238,6 @@ static int __devexit sh_keysc_remove(str
 
 	input_unregister_device(priv->input);
 	free_irq(platform_get_irq(pdev, 0), pdev);
-	input_free_device(priv->input);
 	iounmap(priv->iomem_base);
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help