Re: [PATCH] [repost] Make real parent for ACPI button input devices
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-02-29 01:28:49
Also in:
linux-acpi, lkml
On Thu, 28 Feb 2008 21:14:26 +0300 Andrey Borzenkov [off-list ref] wrote:
quoted hunk
From: Andrey Borzenkov <redacted> Make sure input device for ACPI button gets proper place in device tree. Signed-off-by: Andrey Borzenkov <redacted> --- drivers/acpi/button.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index 24a7865..6c5da83 100644 --- a/drivers/acpi/button.c +++ b/drivers/acpi/button.c@@ -449,6 +449,7 @@ static int acpi_button_add(struct acpi_device *device) input->phys = button->phys; input->id.bustype = BUS_HOST; input->id.product = button->type; + input->dev.parent = &device->dev; switch (button->type) { case ACPI_BUTTON_TYPE_POWER:
What are the consequences of the bug which you've fixed? It helps very much if the changelog explains things like this so we can decide whether the patch is needed in 2.6.25 or even 2.6.24.x. Thanks.