Re: [PATCH 1/6] Core driver for WM97xx touchscreens
From: Dmitry <hidden>
Date: 2008-02-13 11:32:45
Also in:
lkml
From: Dmitry <hidden>
Date: 2008-02-13 11:32:45
Also in:
lkml
Hi, 2008/2/13, Mark Brown [off-list ref]:
On Tue, Feb 12, 2008 at 10:58:50PM +0000, Dmitry Baryshkov wrote:quoted
You used platform_device_register, but should be using platform_device_add, otherwise you get barfs with 2.6.25-rc1 (device is initialized twice). AlsoThanks for that. I feel like I should knock up a patch to clarify the platform API documentation here.
:)
quoted
as <sound/driver.h> got deprecated there is no point including it.Indeed - this is bit rot due to the age of the driver. Hopefully it will make it into at least 2.6.26.
Hope so too. It should be in the mainline since long ago.
BTW, could you please keep at least me in the CC list when discussing these patches? It's easy to miss things on the lists and they're one of the first things I stop reading when I'm busy.
Sorry. I often reply to the patchserie via gmane and it doesn't honour non-ml addresses. -- With best wishes Dmitry