Re: [PATCH 5/6] Driver for WM97xx touchscreens in streaming mode on PXA2xx systems

Mark Brown wrote:

On Mon, Jan 14, 2008 at 10:56:06AM +0100, Marc Kleine-Budde wrote:

quoted

reMark Brown wrote:

quoted

quoted

Cc: Marc Kleine-Budde <redacted>

                                ^^
it's mkl@pengutronix.de

Fixed, sorry about that.

quoted

quoted

+			/* use PEN_DOWN GPIO 13 to assert IRQ on GPIO line 2 */
+			wm->pen_irq = MAINSTONE_AC97_IRQ;

quoted

I'm missing some kind of abstraction here, what about non mainstone
boards with the pen irq wired to some other gpio?

The driver really isn't intended to cope with them.  As you say, other
boards may have things wired up differently and therefore require
different configuration of the wm97xx and other bits of the system.  The
expectation is that other systems will have their own driver.

What bits have to setup in a different way? Only the stuff in
wm97xx_acc_startup() or other things aswell. An irq can be put as utual
into a device's resouce, Setting up bits may be done like other stuff on
pxa, too. e.g. pxa_set_ohci_info.

My initial thought is that the most straightforward way of handling this
would be to rename the driver to mainstone-wm97xx or similar to make it
clear that the driver is only intended to handle Mainstone as-is.  Does
that seem reasonable?

With my limited understanding of the pxa-wm97xx.c file, the only board
dependent stuff is done in wm97xx_acc_startup() so a different "driver"
for other boards would result in code duplication.

regards - Marc

-- 
 Marc Kleine-Budde              Phone: +49-231-2826-924
 Pengutronix - Linux Solutions for Science and Industry
 Vertretung West/Dortmund     http://www.pengutronix.de