Re: [HP6XX/FIX/PATCH] - Fix bad default keymap in HP Jornada 6xx keyboard driver
From: Paul Mundt <hidden>
Date: 2007-12-16 12:51:53
Also in:
lkml
From: Paul Mundt <hidden>
Date: 2007-12-16 12:51:53
Also in:
lkml
On Wed, Dec 12, 2007 at 07:54:52PM +0100, Kristoffer Ericson wrote:
On Thu, 13 Dec 2007 03:45:58 +0900 Paul Mundt [off-list ref] wrote:quoted
On Wed, Dec 12, 2007 at 07:22:07PM +0100, Kristoffer Ericson wrote:quoted
* This patch fixes the HP Jornada 6xx keyboard default keymap which had some bad keymap values. This resulted in wrong key being returned when pressed (example : key y returned 'r').You do realize that the default keymap was written for the Japanese units and the Japanese keyboards, right? From the looks of it, you are just trying to swap one functional set for another. I can assure you that this keymap worked fine on the Japanese units, so calling it a bug is a bit misleading.Mostly true yes. However a few errors entered simply due to me copying the keymap poorly in the initial keymap. So it does infact have 'bug' keys that wouldn't work properly on neither japanese / european / US jornadas. And whatever functional set, this patch fixes those bugs.
Ah, ok, so it's a problem with the new driver, rather than something that's always been broken. No objections then, thanks for clearing that up.