On Tuesday 06 November 2007, Dmitry Torokhov wrote:

Hi Andrey,

On Nov 6, 2007 12:51 PM, Andrey Borzenkov [off-list ref] wrote:

quoted

Properly set up parent on input device registered by the button driver.

Seems to be a popular topic today :)

quoted

+       input->cdev.dev = &device->dev;

Please don't use cdev, but rather input_dev->dev.parent. cdev is going
away soon.
I sent a patch a couple of days ago to teh acpi list...

You mean button patch? I could find only video one.

Just in case, here is updated version.

Subject: [PATCH] Make real parent for ACPI button input devices
From: Andrey Borzenkov <redacted>



Signed-off-by: Andrey Borzenkov <redacted>

---

 drivers/acpi/button.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 24a7865..6c5da83 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c

@@ -449,6 +449,7 @@ static int acpi_button_add(struct acpi_device *device)
 	input->phys = button->phys;
 	input->id.bustype = BUS_HOST;
 	input->id.product = button->type;
+	input->dev.parent = &device->dev;
 
 	switch (button->type) {
 	case ACPI_BUTTON_TYPE_POWER: