Thread (23 messages) 23 messages, 7 authors, 2007-12-19

Re: [PATCH] Fujitsu application panel driver

From: Robert Gerlach <khnz@gmx.de>
Date: 2007-11-19 20:37:30
Also in: lkml

Am Montag 19 November 2007 18:26:32 schrieben Sie:
On Mon, 19 Nov 2007 13:50:30 +0100

Robert Gerlach [off-list ref] wrote:
quoted
Am Montag 19 November 2007 05:43:07 schrieb Stephen Hemminger:
quoted
On Sun, 18 Nov 2007 23:36:58 +0100

Robert Gerlach [off-list ref] wrote:
quoted
Am Dienstag 23 Oktober 2007 21:55:55 schrieb Stephen Hemminger:
quoted
+MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:*");
+MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifebook*:pvr*:rvnFUJITSU:*");
Please make sure that this module is not autoload on Lifebook tablets
(T series and P1[56]10). It works fine, but only supports a subset of
features (4 of 7 buttons and no display orientation for my T4010).
I would rather get those tablets working (with help). Rather than
trying to enumerate all the possible DMI values of the full range of
different laptops.
I've played with apanel some month ago. I've never found the keys and the
switch over the I2C bus. So I was starting my own module (fsc_btns) to
play with the IO range announced by ACPI. There I found it all. But my
module doesn't work on all Lifebooks (S7110 for example; has no such ACPI
device).
If the device doesn't have the buttons, then the probe routine won't find
them and it should just exit and unload itself.  Now it may be too noisy
right now and it might not detect properly, if so, that is where the bug
is.
Sorry, bad writing. What I want to say, apanel loads fine and works for the 4 
keys. Apanel and fsc_btns works side by side too and (in this case) keys 
reported twice, that's the bug.

For my T4010, apanel found 2 devices, devno 1 and 6 both with method=4 chip=4 
slave=25. The working keys are scrolldown (reported as prog2), scrollup 
(prog1), display rotation (www) and Fn (mail). If I find a way to make the 
other keys work, I will happily add it. Currently I have no idea.

By the way, input-kbd segv for apanel on my box. This fixed it for me:
--- orig/apanel.c	2007-11-19 20:41:58.000000000 +0100
+++ apanel.c	2007-11-19 20:44:54.000000000 +0100
@@ -274,8 +274,8 @@
 	idev->phys = "apanel/input0";
 	idev->id.bustype = BUS_HOST;
 	idev->dev.parent = &ap->client.dev;
-	idev->getkeycode = apanel_getkeycode;
-	idev->setkeycode = apanel_setkeycode;
+	idev->keycode = ap->keymap;
+	idev->keycodesize = sizeof(ap->keymap[0]);
 
 	set_bit(EV_KEY, idev->evbit);
 

  Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help