Re: Problem with appletouch driver in Linux version 2.6.23-rc7
From: Matthew Garrett <mjg59@srcf.ucam.org>
Date: 2007-09-24 12:49:31
From: Matthew Garrett <mjg59@srcf.ucam.org>
Date: 2007-09-24 12:49:31
On Mon, Sep 24, 2007 at 08:40:56AM -0400, Dmitry Torokhov wrote:
On 9/22/07, Thomas Rohwer [off-list ref] wrote:quoted
I tried Linux version 2.6.23-rc7 on my macbook pro using the appletouch input driver. I noticed that often release events for the touchpad button are missing. This does not occur with Linux version 2.6.22. I suppose this is related to the new reset logic in the driver introduced in 2.6.23. If a reset occurs while the button is pressed the release event seems to be not sent sometimes. The attached patch fixes the problem for me. It changes the count towards idle so that the count is only incremented if the touchpad button is not pressed. I also attached the output of lsusb.txt.
I'd spotted this, but hadn't got around to fixing it yet. Thanks for picking it up!
I will fix these up myself, you don't need to resubmit the patch. I only need "Signed-off-by: ... " line from you. Thanks!
Acked-by: Matthew Garrett <mjg59@srcf.ucam.org> -- Matthew Garrett | mjg59@srcf.ucam.org