Re: build #315 failed for 2.6.23-rc6-gd017464 in linux/./drivers/input/joystick/xpad.c

Hi Toralf,

On Sunday 16 September 2007 12:46, Toralf Förster wrote:

Hello,

the build with the attached .config failed, make ends with:
...
  CC      arch/i386/lib/strstr.o
  CC      arch/i386/lib/usercopy.o
  AR      arch/i386/lib/lib.a
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `xpad_disconnect':
xpad.c:(.text+0x18ba72): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `xpad_probe':
xpad.c:(.text+0x18c565): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1

Thank you for the report. I believe the patch below should fix the problem.

-- 
Dmitry

Subject: Input: xpad - fix dependancy on LEDS class

Input: xpad - fix dependancy on LEDS class

The driver can not be built-in when LEDS class is a module.

Signed-off-by: Dmitry Torokhov <redacted>
---
 drivers/input/joystick/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/input/joystick/Kconfig
===================================================================

--- linux.orig/drivers/input/joystick/Kconfig
+++ linux/drivers/input/joystick/Kconfig

@@ -277,7 +277,7 @@ config JOYSTICK_XPAD_FF
 
 config JOYSTICK_XPAD_LEDS
 	bool "LED Support for Xbox360 controller 'BigX' LED"
-	depends on LEDS_CLASS && JOYSTICK_XPAD
+	depends on JOYSTICK_XPAD && (LED_CLASS=y || LED_CLASS=JOYSTICK_XPAD)
 	---help---
 	  This option enables support for the LED which surrounds the Big X on
 	  XBox 360 controller.