Re: [PATCH] input: Silence 'unused variable' warning in iforce joystick driver
From: Satyam Sharma <hidden>
Date: 2007-08-30 22:44:53
Also in:
lkml
Hi, On Fri, 31 Aug 2007, Jesper Juhl wrote:
quoted hunk ↗ jump to hunk
In the iforce driver we currently get this warning drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet': drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status' if CONFIG_JOYSTICK_IFORCE_USB is not defined. The warning is easy to avoid by simply moving the variable inside the only case in the switch that actually use it. Signed-off-by: Jesper Juhl <redacted> ---diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c index 3154ccd..48d4a86 100644 --- a/drivers/input/joystick/iforce/iforce-packets.c +++ b/drivers/input/joystick/iforce/iforce-packets.c@@ -246,13 +246,12 @@ void iforce_process_packet(struct iforce *iforce, u16 cmd, unsigned char *data) int iforce_get_id_packet(struct iforce *iforce, char *packet) { - int status; - switch (iforce->bus) { case IFORCE_USB: - #ifdef CONFIG_JOYSTICK_IFORCE_USB + int status; + iforce->cr.bRequest = packet[0]; iforce->ctrl->dev = iforce->usbdev;
Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y?
[ I didn't know mixing code and declarations (not at top of statement
block) was accepted style in the kernel ... ]
IMHO either you should at least wrap that case inside a {} of its
own (so that the int status; is at top of a statement block), or else,
preferably, just add "__maybe_unused" to the first declaration that you
removed just now.
Satyam