Re: [PATCH] input: change SysRq keycode for systems without SysRq key
From: federico ferri <hidden>
Date: 2007-07-15 18:34:52
From: federico ferri <hidden>
Date: 2007-07-15 18:34:52
Linus Torvalds ha scritto:
On Sun, 15 Jul 2007, federico ferri wrote:quoted
this patch adds an entry in Kconfig after 'config MAGIC_SYSRQ' which asks for a different keycode (replacing also KEY_SYSRQ with CONFIG_MAGIC_SYSRQ_KEYCODE in char/keyboard.c)Quite frankly, I think that if we want to make something like this configurable, it should be dynamic, not compiled-in. So that the same kernel image can be used with different keyboards. Linus
That's right; but let me explain: I started this as a hack, just because I both wanted to use this Apple USB keyboard and wanted to be able to hit SysRq. I have no experience at all in programming kernel. Even that small patch it was reviewed and corrected by some people on kernel and input mailing lists. (I can imagine it could be done via a /proc/sysrq-keycode virtual file, but that's just one possibility) So, this should turn into a feature request... would you accept feature requests? ( : -- Federico Ferri