Re: [PATCH] USB: driver for CM109 chipset
From: Vojtech Pavlik <hidden>
Date: 2007-07-12 22:38:08
On Thu, Jul 12, 2007 at 12:22:10PM -0400, Dmitry Torokhov wrote:
quoted
quoted
Hmm, they use KEY_0 through KEY_9 now.Which results in the phone sending 'é+ěščřžýáí' instead of '0123456789' on a Czech keyboard, which is definitely not what's intended. Similarly for many other European keyboards.Hmm, I uttely confused. Why when atkbd emits KEY_0 it you get 0 in the shell (don't you?) but different result with phone keypad?
No, on a Czech keyboard you don't. You press KEY_0, you get 'é'. The French layout gives sililar results. (For '0' you need to press KEY_SHIFT KEY_0.)
quoted
I'll have to figure out where does KEY_103RD come from. I believe it was defined as a key similar to KEY_102ND on specific national keyboards. Brazil springs to mind, but I might be completely wrong. If it's not in use today, we might as well kill it and reuse the code.You had it in the beginning but it was removed around 2.6.2 so 84 is free at the moment.
OK then.
quoted
I don't think that it'd be a huge problem to expand KEY_MAX. I'm not entirely convinced we want to have a different event code for every different key numbered '5'.But they are different as in people expect different actions when they press 5 on the keyboard, keypad, remote control and phone, don't they?
Maybe yes. If they had a input device from hell combining all this functionality into one, they'd likely still want to differentiate between the keys.
Well, maybe not... I can argue both ways I guess... It's more like people may not want input from certain devices be used by certain programs (like they don't like RC cause numbers to be printed in the shell).
But people like the fact that the 'voip' phone devices type regular keys into the voip client programs, because that's what the programs expect, the keys typed on a regular keyboard ... You can't win in all cases.
So far they used grabbing on the devices but I don't think this is sustainable in the long run.
They likely want per-device keymaps. This would also allow to have two keyboards, with different language layouts, connected at the same time. I know a number of people asked how to do that in the past. -- Vojtech Pavlik Director SuSE Labs