Thread (4 messages) 4 messages, 2 authors, 2007-05-27

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

From: Dmitry Torokhov <hidden>
Date: 2007-05-27 03:40:27
Also in: linux-acpi

Possibly related (same subject, not in this thread)

On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote:
Add hotkeys available in almost all ThinkPads manufactured in the last five
years (more than one million machines given the ammount of batteries
recalled) to input.h, and make thinkpad-acpi use those instead of issuing
KEY_UNKNOWN.

KEY_FN_PAGEDOWN is not ever reported by the ThinkPad firmware due to random
bogon-induced stupidity at IBM some years ago, but it is provided because
it doesn't make sense to define KEY_FN_PAGEUP and not define
KEY_FN_PAGEDOWN at the same time.
I am unconvinced that we need new keycodes. Isn't there a better default
keycodes for these keys? You mentioned that fn+f5 controls radio on many
thinkpads, why don't you use KEY_WLAN in your keymap?
 
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help