Re: [PATCH] playing ff effect with code greater then FF_EFFECTS can cause buffer overflow

On Tuesday 01 May 2007 19:20, Jiri Kosina wrote:

On Wed, 2 May 2007, Jan Kratochvil wrote:

quoted

  i found a bug in ff-memless.c so i fixed it. As you can see I am doing 
check if effect_id is less then 0, but I am aware that it is useless 
because effect_id is actually input_event.code which is __u16, but on 
the other side as long as the effect_id is int I feel it is correct to 
check whether it is > 0.

Dmitry,

actually, looking at the code - is there any particular reason for the 
inconsistency between the types used in struct input_event ( __u16 type; 
__u16 code) and in the rest of the code (basically unsigned int 
everywhere)?

input_event is part of ABI and I guess Vojtech tried to pack it to minimize
memory copying. However it is just easier to use unisgned int elsewhere in
the kernel - you either pass values in registers on on stack using native
word size.
  
-- 
Dmitry