Re: [PATCH 0/2] wistron_btns: More keymaps

On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote:

Hi Eric,

On 3/13/07, Eric Piel [off-list ref] wrote:

quoted

Hello,

As a sequel to my patch "Wistron button support for TravelMate 610" of
last week, here is a bigger addition of keymaps for the wistron_btns.

Patch 1 adds all the database of acerhk which fits this driver (about 25
more laptops).
Patch 2 adds a generic map that should fit most users but has the
disadvantage of not being automatic.

Dmitry, I've tried to make them against your tree. Still, if they don't
apply cleanly, just tell me and I'll try harder!

I have couple of comments/requests:

1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the
lid, they correspond to Accpication Control Open and Close keys from
USB HID HUT spec:

    http://www.usb.org/developers/devclass_docs/Hut1_12.pdf

SW_LID shoudl be used to signal lid state instead.

2. I also have a concern about using KEY_SCREEN to signal toggling
display on and off. I am CCing Vojtech - he must know what the
original intent of this key code was. BTW, when user presses
corresponding button - does the display actually goes off? Maybe we
need another switch.

Sorry, Dmitry, I probably should have documented it back then, I don't
have the slightest idea anymore.

3. The number of keymap tables grew considerably ;) Do you think it
woudl make sense to allocate memory for keymap at device creation time
and copy selected keymap and them mark all original keymaps as
__initdata so they are discarded one module completed initialization?

Thank you.

-- 
Vojtech Pavlik
Director SuSE Labs