Re: Fix locking in mousedev

On Fri, 9 Mar 2007 09:28:49 -0500, "Dmitry Torokhov" [off-list ref] wrote:

On 2/28/07, Pete Zaitcev [off-list ref] wrote:

quoted

Dmitry, please consider getting rid of the list of handles entirely.
The other major user is drivers/char/keyboard.c.

I agree that handlers should not access h_list nad use their own
private lists instead. However input core still needs that list to
maintain its books.

Hmm. So it appears that my patch wastes 2 ulongs per input handle
then, in the name of preventing oopses. OK.

I agree with the patch, unfortunately in lands squarely in the middle
of me restructuring the code (swiitch to struct device, proper
refcounting, etc) but I will try to adopt it.

Don't worry about this too much, I can always retest and resubmit,
as long as the main idea is agreeable to you. My users are on RHEL.
Therefore, my main concern is to get something into your tree in
order to avoid this regressing in the future. Meanwhile, users of
our 2.6.9 and 2.6.18 forks get a version of this patch.

-- Pete