Thread (19 messages) 19 messages, 5 authors, 2007-02-25

Re: [KJ][RFC][PATCH] BIT macro cleanup

From: Richard Knutsson <hidden>
Date: 2007-02-25 15:45:20
Also in: kernel-janitors, lkml

Milind Arun Choudhary wrote:
why bitops.h? coz BIT qualifies for a "bitop" 
& bitops.h is  inclued by kernel.h, hence accessible from every part 
of the tree without mucb efforts
  
I don't think there is anyone who objects to this
c>but it is not sutaible for  those who want to go beyond this limit, 
as they will not be warned 
  
And this is the reason for this overly long thread :)
So all we need is  people to be carefull  before passing anything to BIT
  
This is the difficult thing to do
so  now i think it should be ok to have

#define BIT(nr) (1UL << ((nr) % BITS_PER_LONG))
#define LLBIT(nr) (1ULL << (nr))


thoughts
  
Since you guys seems in agreement about the silenced compiler-warnings, 
then I will rest my case.

Richard Knutsson
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help