Re: [PATCH] Added device to hid-ff

On 2/15/07, Anssi Hannula [off-list ref] wrote:

Dmitry Torokhov wrote:

quoted

On 2/15/07, STenyaK (Bruno Gonzalez) [off-list ref] wrote:

quoted

Sorry for not providing a proper patch, could you please also add
        {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel
to the list? I tested it here and that wheel is also working.

OK.

Hmm.. Shouldn't an entry also be added to the devices[] list in
hid-lgff.c for these devices? (and it seems one device is already
missing from there in the current kernel).

Yep. It looks like they should be mapped to ff_joystick, right?

I'm not able to check right now, but I think some earlier kernels may
have defaulted to ff_joystick if no entry is present in devices[], hence
these devices working for some without the entry.
(so the alternative is to restore that behaviour)

BTW, shouldn't the PID/VID check in hid_lgff_init() do endian conversion?

No, because input_id keeps this data in host format. See usb_to_input_id().

-- 
Dmitry