Re: [PATCH 05/16] iio: adc: max1027: Drop extra warning message
From: Jonathan Cameron <jic23@kernel.org>
Date: 2021-08-30 10:09:31
Also in:
lkml
On Wed, 18 Aug 2021 13:11:28 +0200 Miquel Raynal [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Memory allocation errors automatically trigger the right logs, no need to have our own. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/iio/adc/max1027.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c index d79dabf20567..ac603b4ca787 100644 --- a/drivers/iio/adc/max1027.c +++ b/drivers/iio/adc/max1027.c@@ -461,10 +461,8 @@ static int max1027_probe(struct spi_device *spi) st->buffer = devm_kmalloc_array(&indio_dev->dev, indio_dev->num_channels, 2, GFP_KERNEL); - if (st->buffer == NULL) { - dev_err(&indio_dev->dev, "Can't allocate buffer\n"); + if (!st->buffer)
Don't change the form of the check. Whilst it doesn't matter in general which of these is used (and I actually prefer the one you end up with) this change makes this case inconsistent with the style elsewhere in the driver. If you want to clean these all up then I don't mind that, but please do the lot in one patch doing just that. Thanks, Jonathan
return -ENOMEM;
- }
if (spi->irq) {
ret = devm_iio_triggered_buffer_setup(&spi->dev, indio_dev,