Re: [PATCH 05/15] dt-bindings: iio: dac: ad5446: Add missing binding document
From: Rob Herring <robh@kernel.org>
Date: 2021-07-01 14:03:57
Also in:
linux-devicetree
On Sun, 27 Jun 2021 17:32:34 +0100, Jonathan Cameron wrote:
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> Binding is a little stricter than the Linux driver. It requires vcc-supply to be present for devices that don't have an internal reference, whereas the driver just prints a message and carries on. Given this means that it is impossible to establish a scaling of the output channel, let us make it required in the binding schema. Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: Lars-Peter Clausen <lars@metafoo.de> --- .../bindings/iio/dac/adi,ad5446.yaml | 105 ++++++++++++++++++ 1 file changed, 105 insertions(+)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/dac/ti,dac7512.example.dt.yaml: dac@0: 'vcc-supply' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1497723 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.