Thread (2 messages) 2 messages, 2 authors, 2021-07-13

Re: [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol

From: Jonathan Cameron <jic23@kernel.org>
Date: 2021-07-13 17:45:55
Also in: lkml

On Fri,  9 Jul 2021 09:17:27 +0200
Sean Nyekjaer [off-list ref] wrote:
Fix this warning from kernel test robot:
smatch warnings:
drivers/iio/accel/fxls8962af-core.c:640
fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.

Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Sean Nyekjaer <redacted>
Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan
quoted hunk ↗ jump to hunk
---
Changes since v2:
 - add commit msg

 drivers/iio/accel/fxls8962af-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
index 078d87865fde..0019f1ea7df2 100644
--- a/drivers/iio/accel/fxls8962af-core.c
+++ b/drivers/iio/accel/fxls8962af-core.c
@@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
 			return ret;
 	}
 
-	return ret;
+	return 0;
 }
 
 static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help