Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible

On 27/08/16 09:44, Linus Walleij wrote:

On Sat, Aug 27, 2016 at 8:26 AM, Baoyou Xie [off-list ref] wrote:

quoted

We get 2 warnings when biuld kernel with W=1:
drivers/iio/common/st_sensors/st_sensors_trigger.c:69:13: warning: no previous prototype
for 'st_sensors_irq_handler' [-Wmissing-prototypes]
drivers/iio/common/st_sensors/st_sensors_trigger.c:85:13: warning: no previous prototype
for 'st_sensors_irq_thread' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <redacted>

Reviewed-by: Linus Walleij <redacted>

Applied to the togreg branch of iio.git. Initially pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan

Yours,
Linus Walleij