Re: [PATCH v2 37/40] ata: libata: use 16-bits defined sense codes

On 9/3/26 5:41 AM, Damien Le Moal wrote:

Refactor libata core code to use the 16-bits sense_code field of
struct scsi_sense_hdr and replace all hard-coded additional sense codes
and additional sense code qualifiers with the enum values defined in
include/scsi/scsi_sense.h. This helps with code clarity as the sense codes
being processed are easier to test and self-documented.

No functional change intended.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
  drivers/ata/libata-eh.c   |  13 +-
  drivers/ata/libata-sata.c |  20 +--
  drivers/ata/libata-scsi.c | 346 +++++++++++++++++++++++---------------
  drivers/ata/libata.h      |   5 +-
  4 files changed, 229 insertions(+), 155 deletions(-)

Finally :-)

Reviewed-by: Hannes Reinecke <hare@kernel.org>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich