On Mon, Aug 29, 2022 at 6:38 PM Damien Le Moal [off-list ref] wrote:

On 2022/08/29 5:45, Li Zhong wrote:

quoted

sata_scr_read() could return 0 on failure. Check the return value.

Looks OK as a fix but the above sentence has a bug. 0 indicates success, not
failure. So this should read:

sata_scr_read() may fail with a negative error code. Check that function return
value when reading the control register.

Also, the patch title should be something like:

ata: libata-core: Check errors in sata_print_link_status()

Thanks. Will fix it in the new version.

quoted

Signed-off-by: Li Zhong <redacted>
---
 drivers/ata/libata-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 826d41f341e4..ae08c7d35cb0 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c

@@ -3021,7 +3021,8 @@ static void sata_print_link_status(struct ata_link *link)

      if (sata_scr_read(link, SCR_STATUS, &sstatus))
              return;
-     sata_scr_read(link, SCR_CONTROL, &scontrol);
+     if (sata_scr_read(link, SCR_CONTROL, &scontrol))
+             return;

      if (ata_phys_link_online(link)) {
              tmp = (sstatus >> 4) & 0xf;

--
Damien Le Moal
Western Digital Research