Re: [PATCH v3 2/3] ahci: Use macro PCI_DEVICE_ID_AMD_HUDSON2_SATA_IDE
From: Hannes Reinecke <hare@suse.de>
Date: 2021-12-30 13:35:11
Also in:
lkml
On 12/29/21 5:11 PM, Paul Menzel wrote:
quoted hunk ↗ jump to hunk
Use the defined macro from `include/linux/pci_ids.h`. Signed-off-by: Paul Menzel <redacted> --- drivers/ata/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 1e1167e725a4..6a2432e4adda 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c@@ -436,7 +436,7 @@ static const struct pci_device_id ahci_pci_tbl[] = { .class_mask = 0xffffff, board_ahci_al }, /* AMD */ - { PCI_VDEVICE(AMD, 0x7800), board_ahci }, /* AMD Hudson-2 */ + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_HUDSON2_SATA_IDE), board_ahci }, { PCI_VDEVICE(AMD, 0x7900), board_ahci }, /* AMD CZ */ { PCI_VDEVICE(AMD, 0x7901), board_ahci_mobile }, /* AMD Green Sardine */ /* AMD is using RAID class only for ahci controllers */
Weelll ... there are defines for AMD Hudson-2 and similar in the pci_ids file, yet these definitions are not used here. I'd vote keeping the style for all entries, ie either convert all entries here to use #defines, or stay with the numeral. But we shouldn't mix them. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer