Hi Andy,

Thank you for the review.

On Sat, Dec 25, 2021 at 5:02 PM Andy Shevchenko
[off-list ref] wrote:

On Sat, Dec 25, 2021 at 3:55 AM Lad Prabhakar
[off-list ref] wrote:

quoted

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq_optional().

...

quoted

+       irq = platform_get_irq_optional(ofdev, 0);
+       if (irq < 0 && irq != -ENXIO)
+               return irq;
+
+       if (irq > 0) {

quoted

+               memset(&irq_res, 0x0, sizeof(struct resource));

Why do you need that variable at all?

Are you referring to the irq_res variable? That's because
__pata_platform_probe() requires it.

0x0 -> 0
sizeof(irq_res)

OK, I will update it.

Cheers,
Prabhakar