Thread (4 messages) 4 messages, 3 authors, 2021-12-23

Re: [PATCH] ata: libahci_platform: Remove abundant check

From: Sergey Shtylyov <hidden>
Date: 2021-12-23 09:31:25
Also in: lkml

Hello!

On 22.12.2021 10:24, Jiasheng Jiang wrote:
It can be found that platform_get_irq() returns nagative code but not
null when fails.
    s/null/zero/?
The comment of the platform_get_irq clearly shows that.
    This comment still doesn't correspond to reality -- 0 can be returned 
(although this would cause a WARN() call)...
Therefore it should be better to remove the useless check.
    This patch is correct but premature. I have a (not yet merged) patch:

https://marc.info/?l=linux-kernel&m=163623041902285

    It actually disables reporting IRQ0. Until it's merged we have to filter 
out IRQ0 in the libata drivers as libata treats 0 as an indication of the 
polling mode...
Fixes: fd990556f0fa ("ata: move library code from ahci_platform.c to libahci_platform.c")
Signed-off-by: Jiasheng Jiang <redacted>
[...]

MBR, Sergey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help