Hello!

On 3/21/21 10:06 PM, Fabio Estevam wrote:

[...]

   Sorry for replying this late. If I don't reply to mails right away, I tend to forget about
the unreplied mails. I might have been busy with other stuff ATM too... :-)

quoted

If platform_get_irq() returns IRQ0 (considered invalid according to Linus)

How can platform_get_irq() return 0 on i.MX?
This driver only runs on imx31 and imx51 and in both platforms the
PATA IRQ is non-zero.

   Maybe this is impossible indeed -- iff someone doesn't change the kernel (or DT) on purpose
(the driver wouldn't work correctly in this case as libata would ignore the driver's IRQ
handler).

IMHO the current code is correct as-is.

   Not quite... I don't want to leave a bad example for the future driver authors. What should
I change in the patch description for the patch to become acceptable for you?

MBR, Sergey