[PATCH v3 1/9] libata: fix ata_host_alloc_pinfo()
flat view
STALE1899d
SUPERSEDED: 2 (2M)
From: Damien Le Moal <hidden>
Date: 2021-08-06 11:11:52
Also in:
linux-block, linux-scsi
Subsystem:
libata subsystem (serial and parallel ata drivers), the rest · Maintainers:
Damien Le Moal, Niklas Cassel, Linus Torvalds
Revision v3 of 7 in this series; 1 review trailer.
Revisions (7)
Avoid a potential NULL pointer dereference by testing that the ATA port info variable "pi". Reported-by: kernel test robot <redacted> Signed-off-by: Damien Le Moal <redacted> Reviewed-by: Hannes Reinecke <hare@suse.de> --- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 61c762961ca8..ea8b91297f12 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c@@ -5458,7 +5458,7 @@ struct ata_host *ata_host_alloc_pinfo(struct device *dev, ap->link.flags |= pi->link_flags; ap->ops = pi->port_ops; - if (!host->ops && (pi->port_ops != &ata_dummy_port_ops)) + if (!host->ops && pi && pi->port_ops != &ata_dummy_port_ops) host->ops = pi->port_ops; }
--
2.31.1