Thread (2 messages) flat view 2 messages, 2 authors, 2021-05-18

Re: [PATCH] pata_octeon_cf: avoid WARN_ON() in ata_host_activate()

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-05-18 21:23:50

On 5/18/21 2:38 PM, Sergey Shtylyov wrote:
Iff platform_get_irq() fails (or returns IRQ0) and thus the polling mode
has to be used, ata_host_activate() hits the WARN_ON() due to 'irq_handler'
parameter being non-NULL if the polling mode is selected.  Let's only set
the pointer to the driver's IRQ handler if platform_get_irq() returns a
valid IRQ # -- this should avoid the unnecessary WARN_ON()...
Applied, thanks.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help