Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

From
Menglong Dong <hidden>
Date
2021-01-14 14:54:57
Also in
lkml
Reply to
Sergei Shtylyov, 2021-01-14
On Thu, Jan 14, 2021 at 4:30 PM Sergei Shtylyov
[off-list ref] wrote:
[...]
quoted
What does this 'MBR' mean? I am a novice~~~
    Generally speaking, Master Boot Record. But I also use it to send you My
Best Regards. :-)
Haha~,
quoted
So, is it better to replace 'platform_get_irq' with
'platform_get_irq_optional' here?
    No. You should stop overriding the result to -ENOENT and pass the result
up the call chain instead. In order to do it, you should only check for (irq < 0).
Well, I didn't even notice this. It does seem to be another problem...

---
 Best Regards
 Menglong Dong
Thread (6 messages) 6 messages, 2 authors, last reply 2021-01-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help