Thread (18 messages) 18 messages, 16 authors, 2020-09-17

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2020-09-10 10:17:16
Also in: bpf, ceph-devel, dm-devel, dri-devel, intel-gfx, intel-wired-lan, kvmarm, linux-arm-kernel, linux-crypto, linux-fbdev, linux-i2c, linux-input, linux-iommu, linux-media, linux-mediatek, linux-mips, linux-mmc, linux-nfs, linux-pm, linux-rdma, linux-rtc, linux-s390, linux-scsi, linux-sctp, linux-serial, linux-usb, linux-wireless, linuxppc-dev, lkml, netdev, netfilter-devel, nouveau, sparclinux


On 09/09/2020 22:06, Joe Perches wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
index 09f931d4598c..778be26d329f 100644
--- a/drivers/net/wireless/mediatek/mt7601u/dma.c
+++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
@@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb)
  	case -ESHUTDOWN:
  	case -ENOENT:
  		return;
+	case 0:
+		break;
  	default:
  		dev_err_ratelimited(dev->dev, "rx urb failed: %d\n",
  				    urb->status);
-		fallthrough;
-	case 0:
  		break;
  	}
  
@@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb)
  	case -ESHUTDOWN:
  	case -ENOENT:
  		return;
+	case 0:
+		break;
  	default:
  		dev_err_ratelimited(dev->dev, "tx urb failed: %d\n",
  				    urb->status);
-		fallthrough;
-	case 0:
  		break;
  	}
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help